Skip to content

Move EXECUTORCH_PAL_DEFAULT to default preset #10798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Move EXECUTORCH_PAL_DEFAULT to default preset #10798

merged 1 commit into from
May 12, 2025

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented May 10, 2025 •
edited
Loading

Summary

TSIA

Test plan

CI +

$ cmake --preset macos-arm64 && cmake --build cmake-out --parallel

$ cmake -DEXECUTORCH_PAL_DEFAULT=fake --preset macos-arm64

CMake Error at tools/cmake/preset/default.cmake:48 (message):
  PAL default implementation (fake) file not found:
  /Users/jathu/executorch/runtime/platform/default/fake.cpp
Call Stack (most recent call first):
  CMakeLists.txt:53 (include)

cc @larryliu0820

@pytorch-bot
Copy link

pytorch-bot bot commented May 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10798

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Pending

As of commit 83be7d3 with merge base b11807c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2025
@jathu jathu added ciflow/trunk ciflow/binaries topic: not user facing module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch labels May 10, 2025
@jathu jathu force-pushed the jathu/move-EXECUTORCH_PAL_DEFAULT branch from 67fac87 to 8ab14d7 Compare May 12, 2025 14:31
@jathu jathu marked this pull request as ready for review May 12, 2025 14:39
larryliu0820
larryliu0820 reviewed May 12, 2025
View reviewed changes
larryliu0820
larryliu0820 reviewed May 12, 2025
View reviewed changes
@jathu jathu force-pushed the jathu/move-EXECUTORCH_PAL_DEFAULT branch from 8ab14d7 to 83be7d3 Compare May 12, 2025 16:31
@jathu jathu merged commit e113c00 into main May 12, 2025
194 of 196 checks passed
@jathu jathu deleted the jathu/move-EXECUTORCH_PAL_DEFAULT branch May 12, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees

No one assigned

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jathu @larryliu0820 @kirklandsign @facebook-github-bot